Reintroduce quota support, modernized with meson build system #1034
Conversation
This reverts commit 5e05f3b.
Fix some glaring bugs in the code for the 5.99.x quotas (seteuid'ing to group ids, using uninitialized group quota values, etc.) Reviewed-by: Ralph Boehme <[email protected]>
There was a problem hiding this comment.
@rdmark, Great job and detective work! 🕵️♂️
At some point in the near future I would like to rationalise all the dependencies and link args in the meson build system so the netatalk executables and libraries are only linked against those required to provide requested features. So, for example, quota_link_args would not be added to the link_args kwarg if quota support was disabled. At the moment this approach is not consistently applied across the code base.
|
@dgsga Thanks for reviewing. It was surprisingly quite the journey to get to a state that's on par with 2.x. Do you remember the purpose of this line in the root meson.build scripts? I brought it over verbatim from 2.x and it doesn't seem to have an adverse effect (can still enable quota for many Linux flavors) but don't quite understand it. It's obvious why we do this for Darwin (disable quota support), but not sure why it's needed for Linux here. |
|
|
Answering my own question: Without setting NO_QUOTA_SUPPORT for Linux, compilation fails in nfsquota.c across all Linux distros. It's a dirty hack, but we need it for now... |
As per discussion in #1028, bring back quota which was removed within this release cycle.